Pass build options as environment variables (support pyproject.toml migration in CuPy)#414
Merged
Pass build options as environment variables (support pyproject.toml migration in CuPy)#414
pyproject.toml migration in CuPy)#414Conversation
kmaehashi
requested changes
May 19, 2025
kmaehashi
requested changes
May 20, 2025
builder/agent.py
Outdated
Comment on lines
+74
to
+80
| m = _KV_RE.match(kv) | ||
| if m is None: | ||
| raise ValueError(f'Malformed --env argument: {kv}') | ||
| k = str(m.group(1)) | ||
| if k in env: | ||
| raise ValueError(f'Duplicate environment variable: {k}') | ||
| env[k] = str(m.group(2)) |
Member
There was a problem hiding this comment.
I think it's better to keep it as simple as:
pair = kv.split('=', 2)
if len(pair) != 2:
raise ...
env[pair[0]] = pair[1]
Member
Author
There was a problem hiding this comment.
Merged in 77307f9 (len(...) check is further simplified as k, v unpacking) .
Co-authored-by: Kenichi Maehashi <939877+kmaehashi@users.noreply.github.com>
Co-authored-by: Kenichi Maehashi <939877+kmaehashi@users.noreply.github.com>
Co-authored-by: Kenichi Maehashi <939877+kmaehashi@users.noreply.github.com>
kmaehashi
reviewed
May 21, 2025
kmaehashi
previously approved these changes
May 21, 2025
Member
|
/test mini |
Member
|
/test mini |
Member
|
/test mini |
kmaehashi
changed the title
pyproject.toml migration in CuPy)
Member
|
cupy/cupy#9079 has merged. /test mini |
kmaehashi
reviewed
May 21, 2025
kmaehashi
reviewed
May 21, 2025
Member
Author
|
/test mini |
Member
|
/test mini |
kmaehashi
reviewed
May 22, 2025
Member
|
/test mini |
Member
|
/test mini |
kmaehashi
approved these changes
May 23, 2025
chainer-ci
pushed a commit
to chainer-ci/cupy-release-tools
that referenced
this pull request
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cupy/cupy#9079 .