Skip to content

Remove fastrlock from dependency#461

Merged
kmaehashi merged 4 commits intomainfrom
copilot/remove-fastrlock-dependency
Oct 27, 2025
Merged

Remove fastrlock from dependency#461
kmaehashi merged 4 commits intomainfrom
copilot/remove-fastrlock-dependency

Conversation

Copy link
Contributor

Copilot AI commented Oct 17, 2025

This PR removes all references to the fastrlock package from the cupy-release-tools build environment.

Background

The dependency on fastrlock was removed from CuPy itself in cupy/cupy#9414. Since CuPy no longer requires fastrlock, it is no longer needed in the package build environment.

Changes

This PR removes fastrlock from all build configurations:

  • Build configuration: Removed FASTRLOCK_VERSION constant from dist_config.py
  • Docker builds (Linux): Removed fastrlock build arguments from dist.py and both Dockerfile variants (builder/Dockerfile and builder/Dockerfile.el8)
  • Python setup script: Removed fastrlock installation from builder/setup_python.sh
  • Windows builds: Removed fastrlock installation from .pfnci/wheel-windows/build.ps1

The changes are minimal and focused solely on removing fastrlock-related code without affecting any other functionality.

Testing

  • All linting checks pass (ruff, autopep8)
  • All type checking passes (mypy)
  • Verified no remaining references to fastrlock in the codebase

Fixes #[issue_number]

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove fastrlock from dependency</issue_title>
<issue_description>Dependency to fastrlock has been removed in cupy/cupy#9414. The package is no longer required in the package build environment.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #460


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: kmaehashi <939877+kmaehashi@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove fastrlock from project dependencies Remove fastrlock from dependency Oct 17, 2025
Copilot AI requested a review from kmaehashi October 17, 2025 01:37
@kmaehashi kmaehashi marked this pull request as ready for review October 17, 2025 01:39
@kmaehashi
Copy link
Member

Will kick CI after merging #459

@kmaehashi
Copy link
Member

/test mini

@kmaehashi
Copy link
Member

/test mini

@kmaehashi
Copy link
Member

This is ready @asi1024

@kmaehashi kmaehashi merged commit 82f532a into main Oct 27, 2025
4 checks passed
@kmaehashi kmaehashi deleted the copilot/remove-fastrlock-dependency branch October 27, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove fastrlock from dependency

3 participants