Merged
Conversation
Co-authored-by: kmaehashi <939877+kmaehashi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove fastrlock from project dependencies
Remove fastrlock from dependency
Oct 17, 2025
kmaehashi
approved these changes
Oct 17, 2025
Member
|
Will kick CI after merging #459 |
Member
|
/test mini |
kmaehashi
approved these changes
Oct 17, 2025
kmaehashi
reviewed
Oct 17, 2025
Member
|
/test mini |
kmaehashi
approved these changes
Oct 17, 2025
Member
|
This is ready @asi1024 |
asi1024
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all references to the
fastrlockpackage from the cupy-release-tools build environment.Background
The dependency on fastrlock was removed from CuPy itself in cupy/cupy#9414. Since CuPy no longer requires fastrlock, it is no longer needed in the package build environment.
Changes
This PR removes fastrlock from all build configurations:
FASTRLOCK_VERSIONconstant fromdist_config.pydist.pyand bothDockerfilevariants (builder/Dockerfileandbuilder/Dockerfile.el8)builder/setup_python.sh.pfnci/wheel-windows/build.ps1The changes are minimal and focused solely on removing fastrlock-related code without affecting any other functionality.
Testing
Fixes #[issue_number]
Original prompt
Fixes #460
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.