Conversation
Member
Author
|
Again self-merging due to urgency 🙇 cc/ @asi1024 |
chainer-ci
pushed a commit
to chainer-ci/cupy-release-tools
that referenced
this pull request
Feb 16, 2026
Fix NCCL preloading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the verifier to install NCCL with pip instead of
install_library.py.Now that CuPy uses cuda-pathfinder, NCCL installed via
install_library.pywill not be used if cuda-pathfinder can discover NCCL from other locations such as$CUDA_PATH. However, severalnvidia/cudadocker images we use for verification (e.g.nvidia/cuda:12.1.1-runtime-ubuntu22.04) contains outdated NCCL (e.g.libnccl2=2.17.1-1+cuda12.1) which is no longer supported by CuPy. This will causeimport cupy_backends.cuda.libs.ncclto fail withundefined symbol: ncclCommSpliterror, causing the wheel verification process to fail.