Closed
Conversation
Member
Author
|
4 tests fail on Windows. I presume it's due to missing Unicode support in trurl and/or libcurl. All for tests with 'required: "punycode"': When running the first test with wine, Oh, this was with a libcurl-x64.dll picked up by wine from somewhere on the disk, versioned 7.83.1: It fails normally with the matching 8.16.0 dll (latest curl-for-win official): Same failure happens with a 8.15.0 dll with Unicode enabled (a private curl-for-win build): This suggests that trurl doesn't support |
``` trurl.c(463,9): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. trurl.c(2093,41): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. trurl.c(2114,36): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. ```
This reverts commit 6ce457e.
Fixing (MSVC): ``` trurl.c(830,1): warning C4702: unreachable code ``` Ref: https://github.com/curl/trurl/actions/runs/18633529826/job/53121570241#step:5:82
6b21b28 to
426c5d3
Compare
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Oct 21, 2025
vszakats
added a commit
that referenced
this pull request
Oct 31, 2025
vszakats
added a commit
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It supports building the manual, completions, run tests and install all
these.
Options:
TRURL_EMABLE_MANUAL: Build the trurl man page (requires Perl). Default:ONTRURL_COMPLETION_ZSH: Install zsh completions (requires POSIX shell). Default:OFFTRURL_TESTS: Run tests (requires Python). Default:ONTest targets:
trurl-test,trurl-test-memory.TURLS_DISABLE_INSTALL: Disable installation targets. DefaultOFFTRURL_WERROR: Turn compiler warnings into errors. Default:OFFCURL_INCLUDE_DIR: Absolute path to curl include directory.CURL_LIBRARY: Absolute path to libcurl library.CURL_USE_STATIC_LIBS: Look for static libcurl library (requires CMake v3.28).Also:
uses the latest curl-for-win binary from curl.se/windows.
punycodefeature for Windows. It doesn't pass the 4tests requiring this feature, as tested with both Unicode and non-Unicode
libcurl builds.
fopen()andstrerror().CMakeLists.txtitself.To not pollute the source tree in out-of-tree builds.
set -eu.completionsdirectory intoscripts.PATH, except Cygwin.checksrcinto its own job.Also to untie it from
Makefile.