Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Conversation

@phil-flip
Copy link

Here is my little implementation of Docker, inspired by #43
Since I changed some var names inside the code, it needs to be retested without Docker and see, if that still works.
The Docker Compose file has been changed in a way to prevent the need for a docker specific .env file. The normal one can be used.
The DB migration is a hotfix at best and should be redone. I wanted to prevent the use of the .dockerenv check as that might cause issues with other platforms like K8s.
If a merge is undesirable that fine. But I also didn't want to keep it to my self. Let me know, if something doesn't work.

@uchihaservice
Copy link

Thanks, I was actually too lazy to do that :D

@phil-flip
Copy link
Author

phil-flip commented Apr 11, 2024

You're fine. It's just unfortunate, that the owner doesn't seem to merge PRs.

@curtisf
Copy link
Owner

curtisf commented Apr 24, 2024

Could you check out/review the docker-compose.yml in the branch named "selfhost"? That's likely going to be the one that gets distributed for selfhosting in the future.

@phil-flip
Copy link
Author

Everyone has their own taste in Docker-Compose- and Dockerfiles. Personally I don't like it, because it has a lot of extra stuff in it, which is done automatically done by the Docker Compose-Plugin. On the other side, I seem to miss the setup for the DB. The health check is a nice touch tho.
Your Dockerfile should definitely be cleaned up, cause it the current state it requires maintenance when a new file type or folder is added.

@glyzinie glyzinie mentioned this pull request May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants