Skip to content

Add wZEC pool; brownie-token-tester integration#111

Open
samwerner wants to merge 13 commits into
curvefi:masterfrom
samwerner:pool_wzec
Open

Add wZEC pool; brownie-token-tester integration#111
samwerner wants to merge 13 commits into
curvefi:masterfrom
samwerner:pool_wzec

Conversation

@samwerner

@samwerner samwerner commented Jan 24, 2021

Copy link
Copy Markdown
Contributor

What I did

This PR consists of the following changes:

  • Add a StableSwap base pool for wZEC/renZEC
  • Integrate the brownie-token-tester into the test suite to allow for easy minting of tokens for testing
  • Bump isort (removes unknown_third_party issues) and flake8 versions

Note

  • Contracts are not deployed yet

How to verify it

Integation of brownie-token-tester

Run full test suite:
brownie test

Test wZEC Pool

Run test suite:
brownie test --pool wzec

Run test suite against forked mainnet:
brownie test --network mainnet-fork --pool wzec

@halito22 halito22 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thank you

Curve wZEC pool supports swaps between the following wrapped ZEC coins:

- `wZEC`: [0x4A64515E5E1d1073e83f30cB97BEd20400b66E10](https://etherscan.io/address/0x4A64515E5E1d1073e83f30cB97BEd20400b66E10)
- `renZEC`: [0x1c5db575e2ff833e46a2e9864c22f4b22e0b37c2](https://etherscan.io/address/0x1c5db575e2ff833e46a2e9864c22f4b22e0b37c2)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@external
def unkill_me():
assert msg.sender == self.owner # dev: only owner
self.is_killed = False

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

"testing": {
"initial_amount": 100
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants