Complete Rowan parser implementation Part 2 - eliminate legacy AST #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This major refactoring completely removes the legacy AST implementation (syntax::ast and core::desugar::ast modules) and migrates all core desugaring functionality to use the Rowan AST exclusively. Key changes: - Removed syntax::ast and core::desugar::ast modules entirely - Implemented complete core embedding support for Rowan AST in rowan_disembed.rs - Fixed string interpolation with dotted lookup resolution by reproducing the exact legacy InterpolationTarget::Reference algorithm - Added comprehensive test coverage for all core embedding functionality - Updated translation pipeline to handle core expressions properly - All 252 tests now pass with the new implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This commit represents the state after eliminating legacy AST usage from
the core desugaring pipeline. While most functionality works (248/252 tests
passing), there is a critical issue with named input bindings.
Issue: Named inputs are not creating proper bindings. When running with a
named input file, the file content is parsed correctly but the named binding
for the input itself is missing.
Expected: `let data = {parsed_content} in data`
Actual: `let {parsed_content_fields} in data` (unbound reference)
Status:
- ✅ Legacy AST (syntax::ast) completely eliminated
- ✅ Core embedding working with Rowan AST
- ✅ String interpolation partially working
- ❌ Named input bindings broken
- ❌ 4 string interpolation tests failing with dotted lookups
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Apply input names when creating translation units directly from core
expressions (YAML/JSON imports). Previously, the early return path
bypassed the name application that normally happens in the desugarer.
This ensures that `data=yaml@-` correctly creates:
`let data = { foo: "bar" } in data`
instead of:
`let foo = "bar" in data`
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Remove evidence.yaml and simple_subject.yaml (committed by accident) - Remove build.rs (no longer needed after LALRPOP elimination) - Apply formatting fixes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/core/desugar/ast.rsandsrc/syntax/ast.rslegacy AST modulesdata=yaml@-)Key Changes
rowan_disembed.rsmodule provides Rowan-native core embedding functionalitydata=yaml@-was creating individual bindings instead of binding the data structure to the specified namerowan_comprehensive_test.rswith extensive test coverage for core embeddingTest Plan
data=yaml@-)🤖 Generated with Claude Code