Dev 1111 video blocking feature #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
sprankhub
requested changes
Jul 14, 2025
Member
sprankhub
left a comment
sprankhub
left a comment
There was a problem hiding this comment.
Seems to work great in general. Only the flow with product videos is not perfect yet.
Currently:
- Click preview image.
- See preview image.
- See "Please accept" message and click link.
- Accept cookies.
- See preview image again.
- Click preview image.
- See video.
Better:
- Click preview image.
- See preview image.
- See "Please accept" message and click link.
- Accept cookies.
- See video.
Could this be optimised?
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Contributor
Author
Done |
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
sprankhub
requested changes
Jul 29, 2025
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
Signed-off-by: Iman Aboheydary <[email protected]>
sprankhub
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.