1.0#75
Merged
Merged
Conversation
Add resultError() in aresult and use it from ACache and APool so failed queries are not stored or replayed, and callback paths get a proper error AResult instead of an empty one.
Remove open(cb), AResultFn callbacks, AMigrations ready/migrate(cb), and pool setup/reuse callbacks. Use coOpen/co_await, driver signals, and coroutine hooks instead.
Moved AOpenFn, AResultFn, ADatabaseFn, ACoroOpenData, ACoroResult, ACoroDatabase, and ACoroDataRef into src/asql_coro_delivery.h under ASql::detail (with aliases for drivers/core). Removed them from adatabase.h; adriver.h / acoroexpected.h include the delivery header. Header is installed (drivers need it) but documented as not part of the stable public API. 3 — Demos Rewrote coroutine-only demos: pipeline, prepared, deleter, async1, migrations — no leftover onStateChanged / callback exec/open.
(same pattern as migrations) and documented it in apool.h Tests: sqlite_tst multi-statement transaction now uses co_await APool::begin() (TODO removed); existing testPoolBeginCommit / testPoolBeginRollback still cover it Demos: transactions.cpp rewritten around APool::begin(); coroutines.cpp TODO/#if 0 replaced with a live pool-begin demo README: documents APool::begin() alongside ADatabase::begin()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.