Refactor good-first-issue.js for consistency - #1084
Open
Vishal-ghorpade wants to merge 1 commit into
Open
Conversation
What Changed - The old catch (err) block that printed console.error(err) has been replaced. - Now, if the error is a rate limit exceeded (403), it prints a clear warning with guidance. - Any other error prints a short “Unexpected error” message instead of dumping JSON.
Member
|
please fix your formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers 👋,
I noticed that when the GitHub API rate limit is exceeded, the CLI currently prints the full JSON error object. For new contributors, this can be overwhelming and makes the tool harder to use.
This PR improves the developer experience by:
403rate‑limit error inbin/good-first-issue.js.Before:
After:
This change keeps the CLI output clean and beginner‑friendly, while still guiding users toward the right solution. I believe this small improvement makes the tool more approachable for first‑time contributors.
Looking forward to your feedback, and happy to adjust if you’d prefer different wording or formatting.