fix: random pick can reach the last issue - #1101
Open
yugaaank wants to merge 1 commit into
Open
Conversation
Random selection used Math.floor(Math.random() * Math.floor(issues.length - 1)), which made the final issue unreachable. Now uses issues.length so every result has an equal chance of being picked. Fixes cutenode#1100 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100
What
Random issue selection used:
```js
Math.floor(Math.random() * Math.floor(issues.length - 1))
```
The inner `Math.floor(issues.length - 1)` bounded the multiplier so `issues[issues.length - 1]` was never reachable.
Change
```js
const key = cmd.first ? 0 : Math.floor(Math.random() * issues.length)
```
Every returned issue now has an equal chance of being picked, including the last. The inner `Math.floor` was also redundant since `issues.length` is already an integer.
Test
Added `tests/pick.spec.js` guarding the selection bounds (first flag → 0; random pick reaches both first and last index, never out of range). Full `npm test` passes (standard + jest, 100% coverage on touched code).