Remove the third element of the tuple that frames are usually wrapped in #10222
+38
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've always wondered what it was used for. Turns out, absolutely nothing.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10222 +/- ##
==========================================
Coverage 82.62% 82.62%
==========================================
Files 481 430 -51
Lines 49622 46546 -3076
Branches 4174 4174
==========================================
- Hits 40998 38457 -2541
+ Misses 8624 8089 -535
🚀 New features to boost your workflow:
|
Contributor
Author
|
@zhiltsov-max I tried to apply your suggestion from #10215, but the frame tuple types used across the code base vary in what's allowed as the first element, so I wasn't able to reuse the tuple types outside of |
cvat/apps/engine/media_extractors.py
Outdated
Comment on lines
246
to
247
| # In both of these tuples, the first element is either the path to the frame or its contents. | ||
| # In ImageFrame, the second element is the path to the frame. |
Contributor
There was a problem hiding this comment.
Consider adding a docstring. It works at least in VS Code:
Contributor
Author
There was a problem hiding this comment.
Okay, updated. I left VideoFrame without a docstring, since it seems self-explanatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
I've always wondered what it was used for. Turns out, absolutely nothing.
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.