Improve consensus test dropdown testing #10225
Open
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10225 +/- ##
===========================================
- Coverage 75.95% 73.73% -2.23%
===========================================
Files 430 430
Lines 46550 46543 -7
Branches 4174 4174
===========================================
- Hits 35359 34318 -1041
- Misses 11191 12225 +1034
🚀 New features to boost your workflow:
|
Contributor
Author
|
/check |
2 similar comments
Contributor
Author
|
/check |
Contributor
Author
|
/check |
Contributor
|
✔️ All checks completed successfully |
Contributor
|
❌ Some checks failed |
Contributor
|
❌ Some checks failed |
Contributor
Author
|
/check |
Contributor
|
✔️ All checks completed successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Consensus still flakes, example
#10142 didn't account for:
[role="menuitem"]instead of the overlay's<li>which can be ephemeral during rendering. In Ant, overlays are not children of the trigger and are portalled by React so it was less consistentcy.contains('li')matching a hidden item in the wrong timeforce: trueto bypass Cypress actionability checksHow has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.