-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test consensus: merging, ver 2 #9193
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9193 +/- ##
===========================================
+ Coverage 73.34% 73.65% +0.30%
===========================================
Files 449 450 +1
Lines 45868 45847 -21
Branches 3917 3917
===========================================
+ Hits 33644 33769 +125
+ Misses 12224 12078 -146
🚀 New features to boost your workflow:
|
cvat-ui/src/components/consensus-management-page/consensus-settings-tab.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kirill Lakhov <[email protected]>
Co-authored-by: Kirill Lakhov <[email protected]>
}; | ||
const extras = { consensus_replicas: replicas }; | ||
|
||
const taskNameCreate = 'Test consensus creation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to use 1 task spec. In before of each describe
use headlessCreateTask
and delete it in after
|
Depends on #9178
Motivation and context
Test coverage for merging feature in consensus jobs (#8953)
Commits were cherry-picked from #9190
How has this been tested?
Case 1: check new merge buttons exist and are visible.
New freshly created jobs have status 'new'. Trying to merge new jobs should result in error notifications and a HTTP 400 status code. All notifications are closed before the next testcase
Case 2: Check consensus management page
Consensus management page has settings for consensus quorum and minimum annotation overlap. Check that the page has fields for both options. If a field is filled incorrectly the form turns red and a message appears under the form. Trying to save options with erroneous forms should do nothing - no requests are sent, no errors shown.
Case 3: Create annotations and check that job replicas merge correctly
Create annotations with one rectangle in job replicas. The rectangle is moved with a step in each job's first frame. This means that after merging, the consensus job will have a rectangle which has to fully match a rectangle inside the replica in the middle.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.