Demo colab is broken

[Nate711]

I had to change ret["inliers"] to ret["inlier_mask"] in several places as well as change

pose = pycolmap.Image(cam_from_world=ret['cam_from_world']) to pose=ret['cam_from_world']

[Phil26AT]

Hey, this was adressed some time ago in #467. Please pull the latest changes.

[Nate711]

Hi, I was only running the colab that you guys provided in this repo's readme: https://colab.research.google.com/drive/1MrVs9b8aQYODtOGkoaGNF9Nji3sbCNMQ . It is still broken.

[Nate711]

Seems like it's still out of date wrt that PR you linked

[Phil26AT]

Thank you for reporting this again. Indeed we only fixed the local demo notebook, and the colab was out of sync. We are sorry for that. For now I created an updated colab here.

Link fixed in PR #479.

[natejenkins]

Hey the colab notebook which is linked in the README has a bug that is fixed in the repo.

The last cell has:

pose = pycolmap.Image(cam_from_world=ret['cam_from_world'])
viz_3d.plot_camera_colmap(fig, pose, camera, color='rgba(0,255,0,0.5)', name=query, fill=True)
# visualize 2D-3D correspodences
import numpy as np
inl_3d = np.array([model.points3D[pid].xyz for pid in np.array(log['points3D_ids'])[ret['inlier_mask']]])
viz_3d.plot_points(fig, inl_3d, color="lime", ps=1, name=query)
fig.show()

but in reality it should be:

viz_3d.plot_camera_colmap(
    fig, ret["cam_from_world"], ret["camera"], color="rgba(0,255,0,0.5)", name=query, fill=True,
    text=f"inliers: {ret['num_inliers']} / {ret['inlier_mask'].shape[0]}"
)
# visualize 2D-3D correspodences
inl_3d = np.array(
    [model.points3D[pid].xyz for pid in np.array(log["points3D_ids"])[ret["inlier_mask"]]]
)
viz_3d.plot_points(fig, inl_3d, color="lime", ps=1, name=query)
fig.show()