Skip to content

Conversation

@justrau
Copy link

@justrau justrau commented Dec 10, 2024

When instantiated using new, the SlugService cannot be overridden by app code.
Resolving SlugService from the container, allows for overriding.

@cviebrock
Copy link
Owner

Thanks for the PR @justrau. Can you look into why the tests are failing?

@justrau
Copy link
Author

justrau commented Dec 16, 2024

@cviebrock I've triggered Actions on my fork's new branch (https://github.com/justRau/eloquent-sluggable/commits/refs/heads/justRau-patch-2/) from master branch and looks like it is a general problem, because the same tests fail with the same messages, even though that branch does not have the code that was changed in this PR.

Tests failure on basically the master branch: https://github.com/justRau/eloquent-sluggable/actions/runs/12354157246/job/34474862720

I currently have no idea, why that error happens.

@justrau
Copy link
Author

justrau commented Dec 16, 2024

Also, I'm running the code from this PR in a production application using https://github.com/symplify/vendor-patches, all's ok.

@justrau justrau closed this by deleting the head repository Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants