Add telemetry toggles#527
Draft
john-odonnell wants to merge 1 commit intomasterfrom
Draft
Conversation
Currently, the authn client support telemetry and trace reporting only if it is enabled by dependent project. Now the authn client can be configured to collect telemetry with the LOG_TRACES and JAEGER_COLLECTOR_URL environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on cyberark/conjur-opentelemetry-tracer#10
Desired Outcome
Currently, the Authenticator Client supports telemetry and trace reporting only if it is enabled by a dependent project. The standalone Client uses a No-op tracer in all contexts:
The Authn Client should be able to report telemetry independently.
Implemented Changes
Use new functions from cyberark/conjur-opentelemetry-tracer#10 to setup desired tracer, and pass it to an
AuthenticateWithContextimplementation.Connected Issue/Story
N/A
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security