Skip to content

Conversation

@ad-daniel
Copy link
Contributor

@ad-daniel ad-daniel commented Oct 14, 2021

Description
This PR adds:

  • if suspensionSpringConstant or suspensionDamperConstant of HingeJointParameters is non-zero, a spring or respectively a cylinder is rendered. As this pertains just to HingeJointParameters, only Hinge2 and Hinge joints are affected
  • An simplified arrowhead was added to all joint axis representations
  • jointParameters also exposes a springConstant and dampingConstant, however also rendering these might be excessive if not misleading. Visually it wouldn't be easy to distinguish these from the actual suspension ones, and moreover these constants are intended to affect the sponginess of the joint limits (the stops), so also rendering them like a suspension might be slightly misleading.

Linescale 0.1
a
Linescale 0.4
b

suspensionSpringConstant == suspensionDamperConstant == 0
f

suspensionSpringConstant != 0 and suspensionDamperConstant == 0
e

suspensionSpringConstant == 0 and suspensionDamperConstant != 0
d

suspensionSpringConstant != 0 and suspensionDamperConstant != 0
c

@ad-daniel ad-daniel added the feature Implementation of a major feature label Oct 14, 2021
@ad-daniel ad-daniel added this to the R2021b-rev1 milestone Oct 14, 2021
@ad-daniel ad-daniel self-assigned this Oct 14, 2021
@ad-daniel ad-daniel added the test suite Start the test suite label Oct 18, 2021
@ad-daniel ad-daniel marked this pull request as ready for review October 18, 2021 06:59
@ad-daniel ad-daniel requested review from a team and omichel October 18, 2021 06:59
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Moose robot, this is hardly visible:
image
Unless you set the WorldInfo.lineScale to 1:
image
Maybe we can change the WorldInfo.lineScale to 1 in this world file in this PR as well?
With the tiago_base robot, you have to look inside to see the spring:
image

@ad-daniel ad-daniel marked this pull request as draft October 18, 2021 16:06
@ad-daniel ad-daniel modified the milestones: R2021b-rev1, R2022a Dec 3, 2021
@omichel omichel modified the milestones: R2022a, R2022b Dec 3, 2021
@ad-daniel ad-daniel modified the milestones: R2022b, R2022c Jun 22, 2022
@ygoumaz ygoumaz modified the milestones: R2023a, R2023b Nov 14, 2022
@ad-daniel ad-daniel closed this Mar 13, 2023
@ad-daniel ad-daniel deleted the feature-render-suspension branch March 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Implementation of a major feature test suite Start the test suite

Development

Successfully merging this pull request may close these issues.

4 participants