Skip to content

Conversation

@ShuffleWire
Copy link
Contributor

@ShuffleWire ShuffleWire commented Oct 7, 2022

Hello,

I'm trying to add french translation to Webots :)
Before doing more, I wish to know if it's the correct way to do.
Question : have your rules on character escape ? for instance i'm using ' for " ' ", is it correct ?
Just to be sure why is there & before some terms ? (eg <source>&amp;Filter</source>)

If there are some French folks in the wild, please give your taught on my translation (I'm french, but more eye to look at it is better :) )

Thanks

@ShuffleWire ShuffleWire requested a review from a team as a code owner October 7, 2022 08:16
@omichel
Copy link
Member

omichel commented Oct 7, 2022

I believe the & character is for keyboard shortcuts (for menus).
Normally, you should HTML for any special character, like &apos; for ', but maybe simply ' is working (you should test it).
If it works, then it is probably better, as more readable.

@omichel
Copy link
Member

omichel commented Oct 7, 2022

If your PR is not ready for review, please turn it into a draft (see right column of this page), and turn it again to "ready for review" once it is.

@ShuffleWire ShuffleWire marked this pull request as draft October 7, 2022 08:23
@ShuffleWire
Copy link
Contributor Author

ShuffleWire commented Oct 7, 2022

I believe the & character is for keyboard shortcuts (for menus). Normally, you should HTML for any special character, like &apos; for ', but maybe simply ' is working (you should test it). If it works, then it is probably better, as more readable.

i don't know if it work, but it mess up VSCode syntax highlighting ! so I would not go that route...

PS : Gitlab have actually interpreted my escape code.... that make my message meaningless. I will edit that !

I do think that your &apos; is better that my `'

@ShuffleWire
Copy link
Contributor Author

ShuffleWire commented Oct 7, 2022

Additionnal question : What the meaning of type="unfinished" ? I initially thought that it was to indicate missing or WIP translation, but the following seems very fine, for instance...

<message>
        <source>Webots cannot compute inertia for ElevationGrid objects.</source>
        <translation type="unfinished">Webots ne peut pas calculer l&apos;inertie pour les objets ElevationGrid.</translation>
    </message>

I've removed it from my translated text, but should I ?

@omichel
Copy link
Member

omichel commented Oct 7, 2022

I am not sure about this unfinished type, probably we simply forgot to remove it. I believe it is better that you remove it from your translations.

@omichel omichel added the enhancement Implementation of a minor feature label Oct 7, 2022
@omichel omichel added this to the R2022b-rev1 milestone Oct 7, 2022
@ygoumaz ygoumaz modified the milestones: R2022b-rev1, R2023b Nov 14, 2022
@omichel
Copy link
Member

omichel commented Mar 13, 2023

I am closing this PR as it was inactive for a long time.

@omichel omichel closed this Mar 13, 2023
@omichel omichel deleted the translate_french branch March 13, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Implementation of a minor feature

Development

Successfully merging this pull request may close these issues.

4 participants