Improved the bounding boxes of the nao to make them not collide #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omichel
requested changes
Dec 2, 2022
Member
omichel
left a comment
omichel
left a comment
There was a problem hiding this comment.
It seems that several motion files don't work any more with this modified robot model...
omichel
reviewed
Dec 5, 2022
Member
omichel
left a comment
omichel
left a comment
There was a problem hiding this comment.
Did you update the screenshot in the initial PR description?
Did you check that all the NAO motions are working fine with the new model?
Contributor
Author
I forgot to do it, it's updated now.
I opened the nao_demo world and all the commands work now. |
omichel
requested changes
Dec 5, 2022
Member
omichel
left a comment
omichel
left a comment
There was a problem hiding this comment.
I would also add a line in the change log about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bounding objects have been improved so that they do not collide anymore when the selfCollision is set to true.
Screenshots
Old bounding objects:
New bounding objects:
