Skip to content

Fix PROTO load when a context path contains backslash #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omichel merged 4 commits into from
Jul 4, 2023
Merged

Fix PROTO load when a context path contains backslash #6288

omichel merged 4 commits into from
Jul 4, 2023
+12 −10

Conversation

@stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Jul 3, 2023

Fixes #6286:
backslash in paths passed to the template PROTO JS script are not correctly escaped producing invalid JS scrips that cannot load the PROTO models.

@stefaniapedrazzi stefaniapedrazzi added bug Something isn't working test distribution Start the distribution test test suite Start the test suite labels Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b-rev1 milestone Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi mentioned this pull request Jul 3, 2023
Closed
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review July 3, 2023 15:47
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner July 3, 2023 15:47
@BenjaminDeleze BenjaminDeleze requested a review from omichel July 4, 2023 05:54
omichel
omichel approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@omichel omichel merged commit 46f8efa into master Jul 4, 2023
@omichel omichel deleted the hotfix-template-engine-context branch July 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omichel omichel omichel approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels

bug Something isn't working test distribution Start the distribution test test suite Start the test suite

Milestone

R2023b-rev1

Development

Successfully merging this pull request may close these issues.

Template importing error when adding new objects On Ubuntu

3 participants

@stefaniapedrazzi @omichel