Skip to content

Add Silo and Ditch PROTO models #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefaniapedrazzi wants to merge 13 commits into from
Closed

Add Silo and Ditch PROTO models #6289

stefaniapedrazzi wants to merge 13 commits into from

Conversation

@stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Jul 3, 2023

Ditto.

@stefaniapedrazzi stefaniapedrazzi added the enhancement Implementation of a minor feature label Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b-rev1 milestone Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi added the test sources Start the sources test on all platforms label Jul 3, 2023
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review July 3, 2023 13:49
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner July 3, 2023 13:49
@BenjaminDeleze BenjaminDeleze self-requested a review July 3, 2023 13:55
BenjaminDeleze
BenjaminDeleze requested changes Jul 3, 2023
View reviewed changes
Copy link

@BenjaminDeleze BenjaminDeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just some minor remarks:

  • It would be nice to integrate the new protos in existing world (in Boomer.wbt for example).
  • The appearance of the Silo does not really match with its icon (in which the Silo is green). And I think that the current appearance of the Silo is too metallic, but that's subjective.
  • As coneHeight is already a variable, it may be nice to make it a parameter as 2 meters could be strange depending on the radius.

@stefaniapedrazzi
Copy link
Member Author

stefaniapedrazzi commented Jul 3, 2023 •
edited
Loading

The appearance of the Silo does not really match with its icon (in which the Silo is green).

It is metallic, so it reflects the background and the appearance depends on the background used in the world.
I will check to reduce the metalness.

@stefaniapedrazzi stefaniapedrazzi marked this pull request as draft July 3, 2023 14:58
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review July 3, 2023 15:56
@stefaniapedrazzi
Copy link
Member Author

stefaniapedrazzi commented Jul 5, 2023

The conflicts has been resolved, but this GitHub PR page doesn't get updated.
I will wait a little bit to check if it changes otherwise I will close this PR and open a new one.

@stefaniapedrazzi stefaniapedrazzi mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenjaminDeleze BenjaminDeleze BenjaminDeleze requested changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels

enhancement Implementation of a minor feature test sources Start the sources test on all platforms

Milestone

R2023b-rev1

Development

Successfully merging this pull request may close these issues.

3 participants

@stefaniapedrazzi @BenjaminDeleze