Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
instanceofby a check withnodeTypewhen possible because it:| Node | Instanceof | nodeType |
| --- | --- | --- |
|Background| 0.06ms | 0.019 ms |
|Shape| 0.27ms | 0.077ms |
|Robot| 0.28ms | 0.09ms |
The only reason to still use
instanceofsometimes it to check for a node and its derived ones. For example, when checkingif (node instanceof WbGroup)it checks against group, but also, pose, transform, solid, and so on.This PR also adds support for
castShadowsandisPickablein WbShape that were missing.