Skip to content

Fix assertion failure with Skin node #6320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omichel merged 1 commit into from
Jul 11, 2023
Merged

Fix assertion failure with Skin node #6320

omichel merged 1 commit into from
Jul 11, 2023

Conversation

@stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Jul 11, 2023 •
edited
Loading

Bounding sphere update could also be requested by the Skin node, so the assertion is wrong and results in a failure.
The assertion is not necessary and can be removed.

This issue occurs only when compiling in debug mode on not with the released versions of Webots.

@stefaniapedrazzi stefaniapedrazzi added the bug Something isn't working label Jul 11, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b-rev1 milestone Jul 11, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jul 11, 2023
@stefaniapedrazzi stefaniapedrazzi added the test sources Start the sources test on all platforms label Jul 11, 2023
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review July 11, 2023 10:54
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner July 11, 2023 10:54
omichel
omichel approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@omichel omichel merged commit 5377e56 into master Jul 11, 2023
@omichel omichel deleted the fix-assertion-failure-in-bounding-sphere branch July 11, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omichel omichel omichel approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels

bug Something isn't working test sources Start the sources test on all platforms

Milestone

R2023b-rev1

Development

Successfully merging this pull request may close these issues.

3 participants

@stefaniapedrazzi @omichel