-
-
Notifications
You must be signed in to change notification settings - Fork 163
Adding Connector Plugin #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding Connector Plugin #1026
Conversation
I don't know anything about Webots Connector, please choose someone else as reviewer @ralphieraccoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralphieraccoon Thank you, this looks quite good.
For wb_connector_lock() I would rather use a service, but this is fine too. We can add a service as well later.
Could you please add a test for this?
No problem! I can write a service if you prefer, I used As for tests, is there a particular robot you'd like to use? I guess I could put a tool changer on a robot arm. Speaking of which, I think |
This is a good point, let's keep consistent with the vacuum gripper.
Whatever robot you prefer. Please add a test for connectors only in this PR. If you want, you can open a separate PR for the vacuum gripper. |
OK, what I think I'll do is add a world to the |
If adding a new world please add it in the webots_ros2_tests package and keep it as simple as possible. It can be UR robot or it can be the one we use for driver tests. |
…pPositionController installed by default.
I've created a new test in I've uploaded a video of the test in action below: Screencast.from.2025-04-16.10-09-05.webmIt works on my machine, I believe it should work on the I'll make a separate PR to add tests for the Hope this works for you, please let me know if there's anything you want changed. |
Description
Integrating the Webots
Connector
node intowebots_ros2
.Affected Packages