Add heart rate and power zone endpoints#378
Open
dragilla wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughAdds Garmin heart-rate and power-zone API methods, exposes them in the demo CLI, tests endpoint and validation behavior, and updates README API coverage statistics. ChangesHeart-rate and power-zone API support
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Demo as execute_api_call
participant Garmin as Garmin
participant API as connectapi
Demo->>Garmin: Invoke zone accessor
Garmin->>API: Request zone endpoint
API-->>Garmin: Return zone payload
Garmin-->>Demo: Display payload
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_heart_rate_zones()for configured heart-rate profilesget_power_zones()for power zones across all supported sportsget_power_zones_for_sport()with normalized and validated Garmin sport keysValidation
pytest -q— 152 passed, 2 skippedruff check .isort --check-only . --skip-gitignoreblack -l 88 --check --diff .mypy garminconnect testscodespell README.md demo.py garminconnect/__init__.py tests/test_garmin_unit.pySummary by CodeRabbit
New Features
Documentation