Skip to content

Convert code for netstandard / 472 / 462. Fix up tests. Correct Typos. etc #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisMcKee
Copy link

@ChrisMcKee ChrisMcKee commented Aug 31, 2018

Hey; I've upgraded the sln to work with netcore as well as framework down to 462.
I've taken the samples out of the sln for now (If they're important prod me and I'll spend the extra ten minutes wiring them in) and there will undoubtedly be some fettling required for the CI server config.

I removed the redis dependency from the tests and swapped it out for https://github.com/poulfoged/redis-inside.
Other than the change (and some typos) the tests all pass fine unaltered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant