Cancel gesture diagram

[Howlmaster]

I fixed the issue : [mobile] Cancel gesture diagram #2738

I took a look at #2745 and I added the cancel gesture to the last the gesture menu.
And now, it meets all expected behaviors.

[raineorshine]

Thanks for your submission! Works great. Thanks for covering all the requirements.

Below are the issues I found. Please let me know if you have any questions. Thanks!

[raineorshine]

Current Behavior

When selected in the command palette, "Cancel" is rendered with the foreground color (white).

Expected Behavior

The selected command should always be rendered with the highlight color (blue).

[raineorshine]

Current Behavior

The Cancel GestureDiagram is slightly too large and is positioned too close to the Help diagram.

Expected Behavior

The Cancel GestureDiagram should be slightly smaller and positioned evenly between the commands that come before and after, just like other commands.

[raineorshine]

Steps to Reproduce

1. Decrease the font size using the font controls in the footer.
2. Activate the Command Palette by inputing a gesture.

Current Behavior

The Cancel GestureDiagram does not scale with font size.

Expected Behavior

The Cancel GestureDiagram should scale with font size like the other GestureDiagrams.

[raineorshine]

Current Behavior

The Cancel GestureDiagram is highlighted (blue) even when a valid gesture (New Thought) is selected.

Expected Behavior

The Cancel GestureDiagram should be dim (gray) when not selected. It should only be highlighted when selected.

[raineorshine]

Steps to Reproduce

yarn test:puppeteer commandPalette

Note that docker is required to run the Puppeteer tests.

Current Behavior

The Puppeteer test are failing because a snapshot is out of date.

You can view the snapshot diff from GitHub Actions in the build artifacts. For more information, see: https://github.com/cybersemics/em/wiki/Testing#5-visual-snapshot-tests

Expected Behavior

The Puppeteer tests should all pass.

To update the snapshots for this test, run:

yarn test:puppeteer commandPalette -u

[raineorshine]

Current Behavior

The Cancel diagram does not show up in the snapshot test for https://github.com/cybersemics/em/blob/5bfeca0d0823f3863d68e6b2202ccef6db8251b5/src/components/modals/TestGestureDiagram.tsx.

Expected Behavior

The Cancel diagram should be added to https://github.com/cybersemics/em/blob/5bfeca0d0823f3863d68e6b2202ccef6db8251b5/src/components/modals/TestGestureDiagram.tsx as requested in the original issue. The snapshot test should be updated once added.

[raineorshine]

@Howlmaster Just checking in! Let me know if you have any questions about the requested changes.

[raineorshine]

Thanks!

Looks like the yarn.lock was inadvertently changed.

[raineorshine]

I see that all of the comments were marked resolved from my previous review, yet I don't see any changes in the diff, which makes it look like they were not addressed. I've unresolved them for now. Are you still working on these?