[*] update the version variable default value to match the current release v2.4.0
#221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello. This variable is automatically set during the release workflow. But thanks anyway. |
pashagolub
changed the title
version variable default value to match the current release v2.4.0
Contributor
Author
|
@pashagolub It's my pleasure to make a little contribution to the community. Could you please double check if the release workflow is working normally and this variable is automatically set? Seems this variable keeps 2.0.0 in recent several releases. |
Collaborator
|
How did you get the binary? Did you download it from GitHub? |
Contributor
Author
|
Oh，I got it. The binary directly downloaded from GitHub has the correct version number. I built the binary from source so got the legacy version number. Anyway, we should have the updated version number in source code, right? |
Collaborator
|
Yeah, I already merged the PR. Thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version number remains 2.0.0 while the the release number has upgraded to v2.4.0. We suggest to update the version number along with the release number to avoid version confusion.