Skip to content

fix runRepairer to check nil in order to avoid SEGV #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YZ775 merged 1 commit into from
Jan 16, 2025
Merged

fix runRepairer to check nil in order to avoid SEGV #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sabakan/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ var (
errNotAvailable = errors.New("no healthy machine is available")
errMissingMachine = errors.New("failed to apply new template due to missing machines")
errTooManyNonExistent = errors.New("too many non-existent control plane nodes")
errClusterNotFound = errors.New("CKE cluster does not exist")

// DefaultWaitRetiredSeconds before removing retired nodes from the cluster.
DefaultWaitRetiredSeconds = 300.0
Expand Down
4 changes: 4 additions & 0 deletions sabakan/integrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ func (ig integrator) runGenerator(ctx context.Context, leaderKey string, cluster
func (ig integrator) runRepairer(ctx context.Context, clusterStatus *cke.ClusterStatus) error {
st := cke.Storage{Client: ig.etcd}

if clusterStatus == nil {
return errClusterNotFound
}

disabled, err := st.IsAutoRepairDisabled(ctx)
if err != nil {
return err
Expand Down