Skip to content

Comments

mtest: repeatedly run docker stop#847

Merged
masa213f merged 1 commit intomainfrom
fix-20260205
Feb 5, 2026
Merged

mtest: repeatedly run docker stop#847
masa213f merged 1 commit intomainfrom
fix-20260205

Conversation

@masa213f
Copy link
Contributor

@masa213f masa213f commented Feb 5, 2026

This PR fixes the following flaky test in the robustness test.

It's likely that docker stop kubelet failed. Therefore, I repeats docker stop until the Node becomes Not Ready.

https://github.com/cybozu-go/cke/actions/runs/21662518767/job/62450652922

Test CKE robustness should not update k8s components
/root/go/src/github.com/cybozu-go/cke/mtest/robustness_test.go:74
  STEP: stopping kubelet @ 02/04/26 07:39:29.946
  [FAILED] in [It] - /root/go/src/github.com/cybozu-go/cke/mtest/robustness_test.go:89 @ 02/04/26 07:42:30.045
• [FAILED] [180.098 seconds]
Test CKE robustness [It] should not update k8s components
/root/go/src/github.com/cybozu-go/cke/mtest/robustness_test.go:74

  [FAILED] Timed out after 180.002s.
  The function passed to Eventually failed at /root/go/src/github.com/cybozu-go/cke/mtest/robustness_test.go:88 with:
  Expected
      <v1.ConditionStatus>: True
  not to equal
      <v1.ConditionStatus>: True
  In [It] at: /root/go/src/github.com/cybozu-go/cke/mtest/robustness_test.go:89 @ 02/04/26 07:42:30.045

@masa213f masa213f marked this pull request as ready for review February 5, 2026 04:27
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Copy link
Contributor

@YZ775 YZ775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit d3cf5d9 into main Feb 5, 2026
7 checks passed
@masa213f masa213f deleted the fix-20260205 branch February 5, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants