Conversation
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky test in the robustness test.
After the #824, the robustness test started failing as follows.
CI log
https://github.com/cybozu-go/cke/actions/runs/21621901325/job/62312619840
Upon checking, when shutting down a CP node in the test, all kube-apiservers sometimes go down simultaneously.
In this case, CKE skips updating the Kubernetes EndpointSlice and it transitions to the
completedstate.And, the test cannot wait for the EndpointSlice update here, and the next update check failed.
I attempted to modify the CKE logic, but it was difficult. So I will check the EndpointSlice update in
Eventually.