Add trusted REST mappings fallback for CRD resources#852
Merged
Conversation
terassyi
force-pushed
the
add-trusted-rest-mappings
branch
from
5c2cec0 to
7431487
Compare
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
terassyi
force-pushed
the
add-trusted-rest-mappings
branch
from
7431487 to
c7d2d1a
Compare
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
Contributor
morimoto-cybozu
left a comment
morimoto-cybozu
left a comment
There was a problem hiding this comment.
こちらでも見ていたのでコメントします。
docs/cluster.md,CHANGELOG.mdへの追記が必要です。docs/user-resources.mdにも追記があると良いと思います。
YZ775
requested changes
Feb 18, 2026
Signed-off-by: terashima <tomoya-terashima@cybozu.co.jp>
terassyi
force-pushed
the
add-trusted-rest-mappings
branch
from
deb1436 to
310539b
Compare
YZ775
approved these changes
Feb 19, 2026
Contributor
YZ775
left a comment
YZ775
left a comment
There was a problem hiding this comment.
LGTM
Thank you for fixing.
morimoto-cybozu
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows pre-registering REST mappings in the cluster config so that CKE
can manage custom resources whose CRDs may not yet be available via
API discovery. When the REST mapper fails, CKE falls back to these
trusted mappings.
Signed-off-by: terashima tomoya-terashima@cybozu.co.jp