-
Notifications
You must be signed in to change notification settings - Fork 1
add ValidatingWebhook for preventing attachment of mantle-related PVs #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
603b8d8
to
d1d8928
Compare
d1d8928
to
d76b667
Compare
df61408
to
bc12e6e
Compare
98e0b68
to
ed5d6b2
Compare
157d536
to
a9393e0
Compare
a9393e0
to
63aa18f
Compare
940f871
to
9651d61
Compare
825469c
to
b7b0700
Compare
molpako
commented
Apr 21, 2025
molpako
commented
Apr 21, 2025
molpako
commented
Apr 21, 2025
peng225
reviewed
Apr 21, 2025
molpako
commented
Apr 21, 2025
molpako
commented
Apr 21, 2025
molpako
commented
Apr 21, 2025
molpako
commented
Apr 21, 2025
molpako
commented
Apr 22, 2025
test/e2e/multik8s/testutil/testdata/pod-volume-mount-template.yaml
Outdated
Show resolved
Hide resolved
peng225
reviewed
Apr 22, 2025
llamerada-jp
requested changes
Apr 22, 2025
56066c0
to
ec11b84
Compare
6faca6d
to
9e6404a
Compare
peng225
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A commit with at title "move testutil to internal directory" contains the changes to the webhook test file. This is not what we expect.
llamerada-jp
approved these changes
Apr 23, 2025
Signed-off-by: Kyori Sakao <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
9e6404a
to
d584c33
Compare
peng225
approved these changes
Apr 23, 2025
satoru-takeuchi
requested changes
Apr 28, 2025
…ed to a pod. Signed-off-by: Kyori Sakao <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Signed-off-by: Kyori Sakao <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Signed-off-by: Kyori Sakao <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Signed-off-by: Kyori Sakao <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Signed-off-by: Shinya Hayashi <[email protected]> Co-authored-by: Yuji Ito <[email protected]> Co-authored-by: Kyori Sakao <[email protected]>
Signed-off-by: Shinya Hayashi <[email protected]> Co-authored-by: Kyori Sakao <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Signed-off-by: Kyori Sakao <[email protected]>
62ec814
to
5072ba0
Compare
satoru-takeuchi
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.