hotfix: add version for CI action#49
Conversation
Confidence Score: 5/5Safe to merge — the change is a one-line env var addition that pins the scharf binary version in an audit step, with no impact on application or test logic. The only change is injecting SCHARF_VERSION=v1.3.1 into the audit step environment. It does not alter any Go source, test code, or other workflow steps, and the risk surface is limited to the CI pipeline itself. No files require special attention; .github/workflows/ci.yml has a minor style inconsistency (missing version comment on the scharf-action SHA) but nothing that affects correctness. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions Runner
participant Checkout as actions/checkout
participant ScharfAction as cybrota/scharf-action
participant SetupGo as actions/setup-go
participant Tests as go test ./...
GH->>Checkout: Checkout repository (SHA-pinned)
GH->>ScharfAction: "Audit GitHub Actions (env: SCHARF_VERSION=v1.3.1)"
ScharfAction-->>GH: raise-error: true (fail if audit fails)
GH->>SetupGo: "Set up Go >= 1.24 (SHA-pinned)"
GH->>Tests: "go mod download && go test ./..."
Reviews (1): Last reviewed commit: "fix: add version for CI action" | Re-trigger Greptile |
| @@ -18,6 +18,8 @@ jobs: | |||
|
|
|||
| - name: Audit GitHub actions | |||
| uses: cybrota/scharf-action@c0d0eb13ca383e5a3ec947d754f61c9e61fab5ba | |||
There was a problem hiding this comment.
The
cybrota/scharf-action step is pinned to a commit SHA but has no inline version comment, unlike the two other action steps which both carry a # vX.Y.Z annotation. Adding the comment makes it easy to cross-check the SHA against a known release tag at a glance without having to look it up in the remote repository.
| uses: cybrota/scharf-action@c0d0eb13ca383e5a3ec947d754f61c9e61fab5ba | |
| uses: cybrota/scharf-action@c0d0eb13ca383e5a3ec947d754f61c9e61fab5ba # vX.Y.Z |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Fix version for unittests to pass on merge