fix: throttle cache synchronization to prevent API call feedback loop#80
Merged
shess-macu merged 1 commit intocyclops-k8s:mainfrom Apr 19, 2026
Merged
Conversation
SynchronizeCachesAsync was running on every heartbeat check interval (1s), causing thousands of HostnameCache API calls per minute. Each sync lists ClusterCache and HostnameCache CRDs, and any save triggers the DNS reconciler which lists them again — creating a feedback loop that never reaches quiescence. Changes: - Decouple cache sync from heartbeat loop with a separate CacheSyncInterval (default 30s), configurable via values.yaml - Skip sync if one is already in progress (non-blocking WaitOne) instead of queuing callers - Force immediate sync only when a cluster is actually removed - Increase DNS probe timeouts from 1s to 5s
nbarber-macu
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SynchronizeCachesAsync was running on every heartbeat check interval (1s), causing thousands of HostnameCache API calls per minute. Each sync lists ClusterCache and HostnameCache CRDs, and any save triggers the DNS reconciler which lists them again — creating a feedback loop that never reaches quiescence.
Changes: