Skip to content

Wrapper script: fix PATH override preventing selection of Cylc version in GUI under Cylc Hub#6616

Merged
oliver-sanders merged 1 commit intocylc:8.4.xfrom
MetRonnie:wrapper
Feb 20, 2025
Merged

Wrapper script: fix PATH override preventing selection of Cylc version in GUI under Cylc Hub#6616
oliver-sanders merged 1 commit intocylc:8.4.xfrom
MetRonnie:wrapper

Conversation

@MetRonnie
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie commented Feb 18, 2025 •
edited
Loading

Closes #5847

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests N/A
  • Changelog entry included if this is a change that can affect users
  • Changelog for wrapper script fix cylc-doc#805
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Feb 18, 2025
@MetRonnie MetRonnie added this to the 8.4.1 milestone Feb 18, 2025
@MetRonnie MetRonnie self-assigned this Feb 18, 2025
@MetRonnie MetRonnie linked an issue Feb 18, 2025 that may be closed by this pull request
Wrapper script sets PATH when running cylc hub which breaks version selection for cylc play in UI #5847
Closed
oliver-sanders
oliver-sanders approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

@oliver-sanders oliver-sanders merged commit 7243bfb into cylc:8.4.x Feb 20, 2025
27 checks passed
@oliver-sanders oliver-sanders mentioned this pull request Feb 20, 2025
Closed
@MetRonnie MetRonnie deleted the wrapper branch February 20, 2025 12:16
@MetRonnie MetRonnie mentioned this pull request Feb 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels

bug Something is wrong :( small

Projects

None yet

Milestone

8.4.1

Development

Successfully merging this pull request may close these issues.

Wrapper script sets PATH when running cylc hub which breaks version selection for cylc play in UI

2 participants

@MetRonnie @oliver-sanders