Skip to content

Fix duplicate task triggers#6625

Merged
hjoliver merged 4 commits intocylc:masterfrom
MetRonnie:task-param
Feb 24, 2025
Merged

Fix duplicate task triggers#6625
hjoliver merged 4 commits intocylc:masterfrom
MetRonnie:task-param

Conversation

@MetRonnie
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie commented Feb 19, 2025

Closes #6619 (comment)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • Changelog entry included if this is a change that can affect users
  • No docs needed
  • Opened on master as this is not an urgent fix

@MetRonnie MetRonnie added small efficiency For notable efficiency improvements labels Feb 19, 2025
@MetRonnie MetRonnie added this to the 8.5.0 milestone Feb 19, 2025
@MetRonnie MetRonnie self-assigned this Feb 19, 2025
@MetRonnie
Copy link
Copy Markdown
Member Author

(Can change to 8.4.x if desired)

@MetRonnie MetRonnie requested a review from wxtim February 20, 2025 11:05
@oliver-sanders
Copy link
Copy Markdown
Member

(Can change to 8.4.x if desired)

Happy to leave here, probs more appropriate for a minor release.

Profiling results show a reasonable reduction in CPU 🎉.

cpu
memory

method
#!Jinja2

[scheduler]
    allow implicit tasks = True

[task parameters]
    run = 1..{{ N }}

[scheduling]
    initial cycle point = 2000
    final cycle point = 2000-01-03
    runahead limit = P0
    [[queues]]
        [[[default]]]
            limit = 500
    [[graph]]
        P1D = """
            @wall_clock => start => foo<run> => bar
            bar:run | foo<run> => baz
        """

[runtime]
    [[root]]
        script = true
        run mode = skip
        [[[skip]]]
            # default run length = PT0S
            outputs = succeeded, run
        [[[outputs]]]
            run = run
$ /usr/bin/time -v cylc vip --no-detach --mode=live -s 'N=<number>'

Copy link
Copy Markdown
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, but consider my suggestion that you test repr?

@hjoliver
Copy link
Copy Markdown
Member

Test added, merging...

@hjoliver hjoliver merged commit b1f3442 into cylc:master Feb 24, 2025
27 checks passed
@MetRonnie MetRonnie deleted the task-param branch February 25, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

efficiency For notable efficiency improvements small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependant task tries to trigger multiple times off same upstream task

4 participants