Merged
Conversation
hjoliver
reviewed
Feb 24, 2025
tox.ini
Outdated
Comment on lines
+22
to
+26
| tests/*: A001, A003, B010, B017, B904, C401, C405, C408, C413, C416, C420, E731, TC001, TC002, TC003, ISC001, N400, SIM117, SIM201, SIM203, SIM300 | ||
|
|
||
|
|
||
| ; for clarity we don't merge 'with Conf():' context trees | ||
| tests/unit/parsec/*: SIM117, TC001, TC002, TC003 | ||
| tests/unit/parsec/*: B017, B904, C408, C413, SIM113, SIM117, TC001, TC002, TC003 |
Member
There was a problem hiding this comment.
Rather than ignoring specific codes, can we just ignore the flake8 extensions as a whole.
E.g:
tests/*: SIM
Rather than:
tests/*: SIM201, SIM203, SIM300
Suggest only using the default flake8 codes for the tests (i.e. turning off all the extensions).
Member
Author
There was a problem hiding this comment.
Except Bugbear 904, apparently.
…ative imports. Added explanation of B904 needing an explicit exception to tox.ini
hjoliver
approved these changes
Feb 26, 2025
Member
hjoliver
left a comment
hjoliver
left a comment
There was a problem hiding this comment.
Looks good, nice clean-up.
(I did a pretty quick pass through, but I think that's enough - it's just tweaking tests, mainly syntax, and they're all passing).
oliver-sanders
approved these changes
Feb 27, 2025
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Mar 5, 2025
…n_cylc_show * upstream/master: (27 commits) tui: open log files in external application (cylc#6611) fix typo in stop.py - options.max_poll -> options.max_polls schema: add first-parent descendants (cylc#6610) doc: improve NamespaceIDGlob description (cylc#6637) Document that "ex" prefix means "exclude" [skip ci] tests: remove string templating in SQL statements (cylc#6631) Merge pull request cylc#6629 from wxtim/tests.flake8 Remove vestiges of authorisation layer removed in cylc#3845 Bump dev version Prepare release 8.4.1 Merge pull request cylc#6578 from MetRonnie/graphql-err-handling Add test Update cylc/flow/etc/examples/expiry/index.rst Correct type annotations Fix duplicate task triggers Add test for duplicate task triggers Pytest: full verbosity for assertions Fix test picking up user global config Wrapper script: fix `PATH` override preventing selection of Cylc version in GUI under Cylc Hub Get poll to return task failure if job/log has been removed. (cylc#6577) ...
Merged
MetRonnie
pushed a commit
to MetRonnie/cylc-flow
that referenced
this pull request
Apr 3, 2025
Run flake8 on the python tests.
wxtim
added a commit
that referenced
this pull request
Apr 7, 2025
Cherry pick #6629 - use Flake8 on tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply basic Flake 8 standards to the tests.
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).