Skip to content

Kill foreground event handlers on timeout#6639

Merged
oliver-sanders merged 5 commits intocylc:8.4.xfrom
hjoliver:foreground-handler-timeout
Apr 2, 2025
Merged

Kill foreground event handlers on timeout#6639
oliver-sanders merged 5 commits intocylc:8.4.xfrom
hjoliver:foreground-handler-timeout

Conversation

@hjoliver
Copy link
Copy Markdown
Member

@hjoliver hjoliver commented Feb 27, 2025

Close #6615

Shutdown handlers aren't run via the subprocess pool, which gets closed on shutdown, so they weren't subject to the process pool timeout. This PR imposes
the timeout on them anyway, outside of the pool.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Feb 27, 2025
@hjoliver hjoliver added this to the 8.4.x milestone Feb 27, 2025
@hjoliver hjoliver self-assigned this Feb 27, 2025
@hjoliver hjoliver force-pushed the foreground-handler-timeout branch from 15736e3 to 4beafcd Compare February 27, 2025 04:02
@hjoliver
Copy link
Copy Markdown
Member Author

hjoliver commented Feb 27, 2025

Result, using the example from the issue:

image

@hjoliver hjoliver force-pushed the foreground-handler-timeout branch from 4beafcd to 8ab929f Compare March 18, 2025 09:36
@hjoliver hjoliver force-pushed the foreground-handler-timeout branch from 8ab929f to 3f1a240 Compare March 18, 2025 09:53
hjoliver and others added 2 commits April 2, 2025 09:37
@hjoliver hjoliver force-pushed the foreground-handler-timeout branch from 98093ca to d4cd41e Compare April 2, 2025 02:18
@oliver-sanders oliver-sanders merged commit 3230c4e into cylc:8.4.x Apr 2, 2025
28 checks passed
@hjoliver hjoliver deleted the foreground-handler-timeout branch April 2, 2025 09:12
@oliver-sanders oliver-sanders modified the milestones: 8.4.x, 8.4.2 Apr 4, 2025
@MetRonnie MetRonnie mentioned this pull request Apr 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is wrong :(

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants