Address some warnings by MetRonnie · Pull Request #6640 · cylc/cylc-flow

MetRonnie · 2025-02-27T15:51:34Z

Spotted in pytest output

`datetime.utcnow()`

Deprecated since version 3.12: Use datetime.now() with UTC instead.

Note

There is a risk with this because using comparison operators (e.g. <) between timezone-aware and naive (timezone-unaware) datetimes results in a type error. However I cannot find any instances of doing any such comparisons, and all the tests are passing.

`sqlite3.connect()`:

Changed in version 3.13: Positional use of the parameters timeout, detect_types, isolation_level, check_same_thread, factory, cached_statements, and uri is deprecated. They will become keyword-only parameters in Python 3.15.

Important

Python 3.15 is coming in Oct 2026, hence I think this ought to go into 8.7.0 at the latest

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
No dependency changes
No tests/docs/changelog needed
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

cylc/flow/wallclock.py

tests/unit/cycling/test_iso8601.py

cylc/flow/wallclock.py

oliver-sanders · 2025-03-04T15:10:07Z

@hjoliver, this PR removes a code block that isn't used any more. Can you have a quick look at it and merge if ok.

MetRonnie · 2025-04-16T13:59:50Z

@hjoliver ping

MetRonnie · 2025-04-23T13:28:42Z

cylc/flow/wallclock.py

-    if custom_time_zone_info is not None:
-        custom_hours = custom_time_zone_info["hours"]
-        custom_minutes = custom_time_zone_info["minutes"]
-        if use_basic_format:
-            custom_string = custom_time_zone_info["string_basic"]
-        else:
-            custom_string = custom_time_zone_info["string_extended"]
-        if date_time_is_local:
-            date_time_hours = TIME_ZONE_LOCAL_UTC_OFFSET_HOURS
-            date_time_minutes = TIME_ZONE_LOCAL_UTC_OFFSET_MINUTES
-        else:
-            date_time_hours, date_time_minutes = (0, 0)
-        diff_hours = custom_hours - date_time_hours
-        diff_minutes = custom_minutes - date_time_minutes
-        date_time = date_time + timedelta(
-            hours=diff_hours, minutes=diff_minutes)
-        time_zone_string = custom_string


@hjoliver, this PR removes a code block that isn't used any more. Can you have a quick look at it and merge if ok.

This code block was previously only used by the Cylc 7 GUI (7.8.15):

cylc-flow/lib/cylc/gui/updater_tree.py

Lines 269 to 277 in e60e8f7

# Task not finished, but has started and has a meant;

# so we can compute an expected time of completion.

tetc_string = (

self._id_tetc_cache.get(id_, {}).get(tetc_unix))

if tetc_string is None:

# We have to calculate it.

tetc_string = get_time_string_from_unix_time(

tetc_unix,

custom_time_zone_info=time_zone_info)

However, even then it looks like it was only used for the same purpose that is already provided by override_use_utc:

cylc-flow/lib/cylc/gui/updater_tree.py

Line 190 in e60e8f7

time_zone_info = self.updater.global_summary.get("time zone info")

cylc-flow/lib/cylc/state_summary_mgr.py

Lines 125 to 128 in e60e8f7

if get_utc_mode():

global_summary['time zone info'] = TIME_ZONE_UTC_INFO

else:

global_summary['time zone info'] = TIME_ZONE_LOCAL_INFO

@hjoliver poke

oliver-sanders · 2025-07-11T10:18:14Z

(bumped to 8.5.0 as this is non-critical, bump back if merged in time)

MetRonnie · 2025-09-29T15:37:41Z

Python 3.15 is out next year, hence I think this ought to go in soon (8.7.0 at the latest)

hjoliver · 2025-12-10T04:21:37Z

Apologies for the massive delay!

hjoliver · 2025-12-10T04:22:54Z

Several conflicts now, sorry.

MetRonnie · 2025-12-10T12:05:35Z

@wxtim Can you check you're happy with the rebase after #6719 was merged: https://github.com/cylc/cylc-flow/compare/a42cea26581794ad04c9737543bc4b7b177900ba..2e01206ebb90dc4a9008dc70aabdf69c5ab632a0

wxtim

Rebase Reviewed

wxtim · 2025-12-10T15:20:04Z

@MetRonnie - Please check the failing test - I've kicked it just in case it's flaky?

MetRonnie · 2025-12-10T16:14:20Z

Just flaky - merging

MetRonnie added the small label Feb 27, 2025

MetRonnie added this to the 8.5.0 milestone Feb 27, 2025

MetRonnie self-assigned this Feb 27, 2025

MetRonnie force-pushed the warnings branch from 727294b to ff3f3aa Compare February 27, 2025 16:35

oliver-sanders reviewed Feb 28, 2025

View reviewed changes

cylc/flow/wallclock.py Show resolved Hide resolved

oliver-sanders reviewed Feb 28, 2025

View reviewed changes

cylc/flow/wallclock.py Show resolved Hide resolved

oliver-sanders reviewed Feb 28, 2025

View reviewed changes

tests/unit/cycling/test_iso8601.py Show resolved Hide resolved

MetRonnie force-pushed the warnings branch from 6c9ace9 to b3edadd Compare March 3, 2025 12:45

MetRonnie commented Mar 3, 2025

View reviewed changes

cylc/flow/wallclock.py Show resolved Hide resolved

MetRonnie force-pushed the warnings branch from b3edadd to 09c52c7 Compare March 3, 2025 12:54

oliver-sanders approved these changes Mar 4, 2025

View reviewed changes

oliver-sanders requested a review from hjoliver March 4, 2025 15:10

MetRonnie mentioned this pull request Apr 9, 2025

Fix.6701.scheduler time zone change bug #6719

Merged

8 tasks

MetRonnie commented Apr 23, 2025

View reviewed changes

oliver-sanders modified the milestones: 8.5.0, 8.6.0 Jul 11, 2025

oliver-sanders modified the milestones: 8.6.0, 8.x Sep 1, 2025

MetRonnie modified the milestones: 8.x, 8.7.0 Sep 29, 2025

hjoliver approved these changes Dec 10, 2025

View reviewed changes

MetRonnie added 3 commits December 10, 2025 11:36

Fix sqlite3.connect() positional arg deprecation

e78a078

Replace deprecated datetime.utcnow()

6e9835e

Remove unused code & tidy

2e01206

MetRonnie force-pushed the warnings branch from a42cea2 to 2e01206 Compare December 10, 2025 12:03

wxtim approved these changes Dec 10, 2025

View reviewed changes

MetRonnie merged commit 043c701 into cylc:master Dec 10, 2025
33 of 34 checks passed

MetRonnie deleted the warnings branch December 10, 2025 16:14

	# Task not finished, but has started and has a meant;
	# so we can compute an expected time of completion.
	tetc_string = (
	self._id_tetc_cache.get(id_, {}).get(tetc_unix))
	if tetc_string is None:
	# We have to calculate it.
	tetc_string = get_time_string_from_unix_time(
	tetc_unix,
	custom_time_zone_info=time_zone_info)

	if get_utc_mode():
	global_summary['time zone info'] = TIME_ZONE_UTC_INFO
	else:
	global_summary['time zone info'] = TIME_ZONE_LOCAL_INFO

Conversation

MetRonnie commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

datetime.utcnow()

sqlite3.connect():

Check List

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oliver-sanders commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MetRonnie commented Apr 16, 2025

Uh oh!

MetRonnie Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliver-sanders Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

oliver-sanders Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

oliver-sanders commented Jul 11, 2025

Uh oh!

MetRonnie commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hjoliver commented Dec 10, 2025

Uh oh!

hjoliver commented Dec 10, 2025

Uh oh!

MetRonnie commented Dec 10, 2025

Uh oh!

wxtim left a comment

Choose a reason for hiding this comment

Uh oh!

wxtim commented Dec 10, 2025

Uh oh!

MetRonnie commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MetRonnie commented Feb 27, 2025 •

edited

Loading

`datetime.utcnow()`

`sqlite3.connect()`:

oliver-sanders commented Mar 4, 2025 •

edited

Loading

MetRonnie Apr 23, 2025 •

edited

Loading

MetRonnie commented Sep 29, 2025 •

edited

Loading