Skip to content

fix typo in stop.py - options.max_poll -> options.max_polls#6646

Merged
oliver-sanders merged 1 commit intocylc:8.4.xfrom
ColemanTom:6645-typo-in-variable-name-in-stop-py
Mar 4, 2025
Merged

fix typo in stop.py - options.max_poll -> options.max_polls#6646
oliver-sanders merged 1 commit intocylc:8.4.xfrom
ColemanTom:6645-typo-in-variable-name-in-stop-py

Conversation

@ColemanTom
Copy link
Copy Markdown
Contributor

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

I did not update any tests. The pathway leads to failure no matter what, this just fixes the exception type and message. No documentation updates are required.

@ColemanTom
Copy link
Copy Markdown
Contributor Author

As a note, I'm kind of surprsied that no CI tools are catching this bug? Misnamed variables should be fairly apparent I would think?

@oliver-sanders
Copy link
Copy Markdown
Member

As a note, I'm kind of surprsied that no CI tools are catching this bug? Misnamed variables should be fairly apparent I would think?

Codecov reports the line as covered, which is is, it's just that a different error gets raised to the one intended.

MyPy raises no concern as Options objects aren't introspectable in this way.

@oliver-sanders oliver-sanders added this to the 8.4.2 milestone Mar 4, 2025
@oliver-sanders oliver-sanders merged commit 16c0e6c into cylc:8.4.x Mar 4, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants