fix typo in stop.py - options.max_poll -> options.max_polls#6646
Merged
oliver-sanders merged 1 commit intocylc:8.4.xfrom Mar 4, 2025
Merged
Conversation
Contributor
Author
|
As a note, I'm kind of surprsied that no CI tools are catching this bug? Misnamed variables should be fairly apparent I would think? |
oliver-sanders
approved these changes
Mar 4, 2025
Member
Codecov reports the line as covered, which is is, it's just that a different error gets raised to the one intended. MyPy raises no concern as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.I did not update any tests. The pathway leads to failure no matter what, this just fixes the exception type and message. No documentation updates are required.