GH Actions: use explicit bash shell & other defaults#6654
Merged
oliver-sanders merged 1 commit intocylc:8.4.xfrom Mar 18, 2025
Merged
GH Actions: use explicit bash shell & other defaults#6654oliver-sanders merged 1 commit intocylc:8.4.xfrom
bash shell & other defaults#6654oliver-sanders merged 1 commit intocylc:8.4.xfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d51f457 to
af6614f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
MacOS unit test failing 3 times in a row with
but is unrelated |
oliver-sanders
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell
This was added to the docs in actions/runner#1955; I was unaware that there was a difference between not specifying the default and specifying
bash.We seem to be missing
-o pipefailby default. (This change will also introduce--norc,--noprofile; not sure why these are included 🤷)Tip
If/when we change to using setup-micromamba/miniconda, we will need to provide the full set of options we want, which will have to include
-l.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.