Skip to content

Prevent illegal platform host broadcast#6711

Merged
wxtim merged 4 commits intocylc:8.4.xfrom
wxtim:fix.6693.prevent-illegal-platform-host-bc
Apr 17, 2025
Merged

Prevent illegal platform host broadcast#6711
wxtim merged 4 commits intocylc:8.4.xfrom
wxtim:fix.6693.prevent-illegal-platform-host-bc

Conversation

@wxtim
Copy link
Copy Markdown
Member

@wxtim wxtim commented Apr 7, 2025 •
edited
Loading

Closes #6693

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim changed the title Fix.6693.prevent illegal platform host bc Prevent illegal platform host broadcast Apr 7, 2025
@wxtim wxtim force-pushed the fix.6693.prevent-illegal-platform-host-bc branch from 065605a to a300ecb Compare April 7, 2025 13:51
@wxtim wxtim force-pushed the fix.6693.prevent-illegal-platform-host-bc branch from a300ecb to 6ed32b3 Compare April 7, 2025 13:54
@MetRonnie MetRonnie added this to the 8.4.x milestone Apr 7, 2025
@wxtim wxtim force-pushed the fix.6693.prevent-illegal-platform-host-bc branch from 6ed32b3 to af113eb Compare April 8, 2025 08:20
@wxtim
Check broadcasts for clashing methods of selecting remote hosts:
a703c10 
Do not allow `[remote]host` in broadcast if `platform` is set,
or vice-versa.
@wxtim wxtim force-pushed the fix.6693.prevent-illegal-platform-host-bc branch from af113eb to a703c10 Compare April 8, 2025 08:55
oliver-sanders
oliver-sanders reviewed Apr 8, 2025
View reviewed changes
Comment thread cylc/flow/broadcast_mgr.py Outdated
@wxtim wxtim requested a review from oliver-sanders April 9, 2025 09:14
oliver-sanders
oliver-sanders reviewed Apr 9, 2025
View reviewed changes
Comment thread cylc/flow/broadcast_mgr.py Outdated
@wxtim wxtim requested a review from oliver-sanders April 10, 2025 12:35
@MetRonnie MetRonnie modified the milestones: 8.4.x, 8.4.3 Apr 14, 2025
MetRonnie
MetRonnie requested changes Apr 16, 2025
View reviewed changes
Comment thread tests/integration/test_broadcast_mgr.py Outdated
Comment thread cylc/flow/broadcast_mgr.py Outdated
Comment thread tests/integration/test_broadcast_mgr.py
@wxtim wxtim requested a review from MetRonnie April 17, 2025 09:53
MetRonnie
MetRonnie approved these changes Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only problem is that there is no error reported in the command line, however this is probably good enough

@wxtim
Copy link
Copy Markdown
Member Author

wxtim commented Apr 17, 2025

Only problem is that there is no error reported in the command line, however this is probably good enough

Oliver tells me it can't be, yet!

@wxtim wxtim merged commit c984044 into cylc:8.4.x Apr 17, 2025
28 checks passed
@oliver-sanders
Copy link
Copy Markdown
Member

oliver-sanders commented Apr 17, 2025

@MetRonnie, see #6574

@wxtim wxtim deleted the fix.6693.prevent-illegal-platform-host-bc branch April 17, 2025 12:53
@wxtim wxtim mentioned this pull request May 12, 2025
Closed
@wxtim
Copy link
Copy Markdown
Member Author

wxtim commented May 12, 2025

Also closes #5979

@MetRonnie MetRonnie linked an issue May 12, 2025 that may be closed by this pull request
platforms: 7/8 syntax mismatch should result in submission failure #5979
Closed
@MetRonnie MetRonnie linked an issue May 12, 2025 that may be closed by this pull request
Invalid Broadcast of Illegal Config breaks scheduler #6693
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels

None yet

Projects

None yet

Milestone

8.4.3

Development

Successfully merging this pull request may close these issues.

Invalid Broadcast of Illegal Config breaks scheduler platforms: 7/8 syntax mismatch should result in submission failure

3 participants

@wxtim @oliver-sanders @MetRonnie