Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes.d/6798.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent unintended submission retries that could result from platform connection issues in certain circumstances.
2 changes: 1 addition & 1 deletion conda-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies:
- python
- pyzmq >=22
- importlib_metadata >=5.0 # [py<3.12]
- urwid >=2,<3,!=2.6.2,!=2.6.3
- urwid >=2.2,<3,!=2.6.2,!=2.6.3
- tomli >=2 # [py<3.11]

# optional dependencies
Expand Down
9 changes: 0 additions & 9 deletions cylc/flow/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1047,15 +1047,6 @@ async def process_command_queue(self) -> None:

self.command_queue.task_done()

def info_get_graph_raw(self, cto, ctn, grouping=None):
"""Return raw graph."""
return (
self.config.get_graph_raw(cto, ctn, grouping),
self.config.workflow_polling_tasks,
self.config.leaves,
self.config.feet
)

def _set_stop(self, stop_mode: Optional[StopMode] = None) -> None:
"""Set shutdown mode."""
self.proc_pool.set_stopping()
Expand Down
4 changes: 3 additions & 1 deletion cylc/flow/task_job_mgr.py
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,11 @@ def _get_platform_with_good_host(
Returns:
The platform with a good host, or None if no such platform is found
"""
out_of_hosts = False
for itask in itasks:
# If there are any hosts left for this platform which we
# have not previously failed to contact with a 255 error.
if any(
if not out_of_hosts and any(
host not in self.task_remote_mgr.bad_hosts
for host in itask.platform['hosts']
):
Expand Down Expand Up @@ -618,6 +619,7 @@ def _get_platform_with_good_host(
itask.platform['name'],
)
)
out_of_hosts = True
done_tasks.append(itask)

return None
Expand Down
Loading