fix reload failures on active/incomplete orphans#6817

Merged

wxtim merged 9 commits intocylc:8.5.xfrom

dwsutherland:reload-xtriggered-task-fixes

Sep 19, 2025

Member

dwsutherland commented Jun 26, 2025 •

edited

Loading

closes #6814
closes #6815

Note - A good way to see the bugs is to comment out a fix and run the test for each.

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
Tests are included (or explain why tests are not needed).
Changelog entry included if this is a change that can affect users
Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

dwsutherland added this to the 8.4.4 milestone

dwsutherland self-assigned this

dwsutherland added the bug label

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from e1b725c to 6e14ae8 Compare

June 26, 2025 01:07

dwsutherland added small labels

dwsutherland mentioned this pull request

set non-existent task while reloading causes crash #6814

Closed

dwsutherland requested a review from MetRonnie

July 2, 2025 03:47

MetRonnie requested a review from wxtim

July 2, 2025 11:29

wxtim reviewed

View reviewed changes

changes.d/6817.fix.md Outdated Show resolved Hide resolved

wxtim reviewed

View reviewed changes

tests/integration/test_reload.py Outdated Show resolved Hide resolved

wxtim reviewed

View reviewed changes

tests/integration/test_reload.py Outdated Show resolved Hide resolved

wxtim reviewed

View reviewed changes

tests/integration/test_reload.py Outdated Show resolved Hide resolved

wxtim reviewed

View reviewed changes

tests/integration/test_reload.py Outdated Show resolved Hide resolved

MetRonnie reviewed

View reviewed changes

changes.d/6817.fix.md Outdated Show resolved Hide resolved

tests/integration/test_reload.py Outdated Show resolved Hide resolved

tests/integration/test_reload.py Outdated Show resolved Hide resolved

tests/integration/test_reload.py Outdated Show resolved Hide resolved

tests/integration/test_reload.py Outdated Show resolved Hide resolved

tests/integration/test_reload.py Outdated Show resolved Hide resolved

This was linked to issues Jul 14, 2025

reload fail on xtrigger removal causing depleted task pool #6815

Closed

set non-existent task while reloading causes crash #6814

Closed

hjoliver reviewed

View reviewed changes

tests/integration/test_reload.py Outdated Show resolved Hide resolved

oliver-sanders modified the milestones: 8.4.4, 8.4.x

MetRonnie force-pushed the 8.4.x branch from bba6f72 to 970df19 Compare

July 22, 2025 09:05

oliver-sanders requested review from MetRonnie and wxtim

August 29, 2025 10:08

Member

oliver-sanders commented Aug 29, 2025 •

edited

Loading

(assigned commenters as reviewers)

@dwsutherland, some comments to address above.

dwsutherland mentioned this pull request

fix no cfg xtrig broadcast delta shutdown #6936

Closed

8 tasks

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from c12deee to 5be6729 Compare

August 29, 2025 23:57

dwsutherland changed the base branch from 8.4.x to 8.5.x

August 29, 2025 23:58

dwsutherland modified the milestones: 8.4.x, 8.5.2

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from 5be6729 to f501070 Compare

August 30, 2025 00:06

MetRonnie reviewed

View reviewed changes

cylc/flow/data_store_mgr.py Outdated Show resolved Hide resolved

cylc/flow/data_store_mgr.py Outdated Show resolved Hide resolved

MetRonnie modified the milestones: 8.5.2, 8.5.3

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from e18e421 to 2e8700b Compare

September 4, 2025 08:55

hjoliver reviewed

View reviewed changes

Member

hjoliver left a comment

(Partially reviewed)

cylc/flow/data_store_mgr.py Show resolved Hide resolved

cylc/flow/network/schema.py Outdated Show resolved Hide resolved

cylc/flow/data_store_mgr.py Outdated Show resolved Hide resolved

wxtim reviewed

View reviewed changes

changes.d/6817.fix.md Outdated Show resolved Hide resolved

MetRonnie reviewed

View reviewed changes

Member

MetRonnie left a comment

Got a test suggestion at dwsutherland#24

MetRonnie modified the milestones: 8.5.3, 8.5.4

dwsutherland and others added 5 commits

September 11, 2025 19:00


          fix reload removed xtrigger data-store task deltas

b72586a


          test added

1f0d336


          changelog entry added

34791d8


          Apply suggestions from code review

740e4c0

Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>


          Use existing node runtime on job insert

0d70707

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from 2c7f18d to 4dbac57 Compare

September 11, 2025 07:18

dwsutherland and others added 3 commits

September 11, 2025 21:24


          various review changes

e6c9975


          Add test & type annotation

fe21d61


          address GQL -> Graphql

64e2fc5

dwsutherland force-pushed the reload-xtriggered-task-fixes branch from 4dbac57 to 64e2fc5 Compare

September 11, 2025 09:25

MetRonnie self-requested a review

September 16, 2025 08:18

hjoliver modified the milestones: 8.5.4, 8.6.0


          Tweak data store tests.

48fb42c

hjoliver approved these changes

View reviewed changes

Member

hjoliver left a comment

LGTM

@dwsutherland - FYI I pushed a small tweak to your branch to get patch coverage up from 69 to 97%.

MetRonnie requested a review from wxtim

September 19, 2025 13:17

wxtim removed the request for review from MetRonnie

September 19, 2025 13:21

wxtim approved these changes

View reviewed changes

wxtim merged commit c2f2915 into cylc:8.5.x

38 of 40 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels