Skip to content

config: turn invalid workflow event errors into warnings#6902

Merged
ChrisPaulBennett merged 1 commit intocylc:8.5.xfrom
oliver-sanders:6870
Aug 8, 2025
Merged

config: turn invalid workflow event errors into warnings#6902
ChrisPaulBennett merged 1 commit intocylc:8.5.xfrom
oliver-sanders:6870

Conversation

@oliver-sanders
Copy link
Copy Markdown
Member

@oliver-sanders oliver-sanders commented Aug 6, 2025 •
edited
Loading

  • Turns out a lot of workflows have invalid mail/handler events.
  • Turn this hard error into a soft warning to make migration easier.
  • Also include the list of valid task events in the config docs. Closes document valid task events #6870

Docs build:

Screenshot from 2025-08-06 16-31-53

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.5.1 milestone Aug 6, 2025
@oliver-sanders oliver-sanders self-assigned this Aug 6, 2025
@oliver-sanders oliver-sanders marked this pull request as draft August 6, 2025 15:38
@oliver-sanders oliver-sanders changed the title config: turn invalid mail event errors into warnings config: turn invalid workflow event errors into warnings Aug 6, 2025
@oliver-sanders
config: turn invalid workflow event errors into warnings
0ff968b 
* Turns out a lot of workflows have invalid mail/handlert pu events.
* Turn this hard error into a soft warning to make migration easier.
* Also include the list of valid task events in the config docs.
  Closes cylc#6870
@oliver-sanders oliver-sanders marked this pull request as ready for review August 6, 2025 15:47
hjoliver
hjoliver approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

MetRonnie
MetRonnie reviewed Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(LGTM from a quick skim)

ChrisPaulBennett
ChrisPaulBennett reviewed Aug 7, 2025
View reviewed changes
Comment thread cylc/flow/cfgspec/globalcfg.py
@ChrisPaulBennett ChrisPaulBennett merged commit dd5c77c into cylc:8.5.x Aug 8, 2025
28 checks passed
@oliver-sanders oliver-sanders deleted the 6870 branch August 8, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisPaulBennett ChrisPaulBennett ChrisPaulBennett left review comments

@MetRonnie MetRonnie MetRonnie left review comments

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels

None yet

Projects

None yet

Milestone

8.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@oliver-sanders @hjoliver @ChrisPaulBennett @MetRonnie