restart timeout: fire event for stop after cycle point scenarios#6903
Merged
hjoliver merged 2 commits intocylc:8.5.xfrom Aug 26, 2025
Merged
restart timeout: fire event for stop after cycle point scenarios#6903hjoliver merged 2 commits intocylc:8.5.xfrom
hjoliver merged 2 commits intocylc:8.5.xfrom
Conversation
oliver-sanders
force-pushed
the
restart-timeout++
branch
2 times, most recently
from
0b96bfc to
aedd419
Compare
oliver-sanders
commented
Aug 6, 2025
| assert schd2.get_events() == {'startup', 'restart timeout', 'shutdown'} | ||
|
|
||
|
|
||
| async def test_restart_timeout_workflow_stop_after_cycle_point( |
Member
Author
There was a problem hiding this comment.
Copy of above test, shimmed to test stop after cycle point.
* If a workflow hits the `final cycle point` and is restarted, it is considered complete. * If a `restart timeout` is configured, the scheduler will stay up for a configured period. * However, if a workflow hits the `stop after after cycle point` and is restarted, the `restart timeout` event is not yielded and the scheduler will instantly shut down again.
oliver-sanders
force-pushed
the
restart-timeout++
branch
from
aedd419 to
8b64627
Compare
wxtim
reviewed
Aug 11, 2025
| if self.is_restart and ( | ||
| # workflow has completed | ||
| not self.pool.get_tasks() | ||
| # workflow has hit the "stop after cycle point" |
Member
There was a problem hiding this comment.
Suggest that this should be documented in globalcfg.py since this setting now applies to stopped as well as completed workflows.
wxtim
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
final cycle pointand is restarted, it is considered complete.restart timeoutis configured, the scheduler will stay up for a configured period.stop after after cycle pointand is restarted, therestart timeoutevent is not yielded and the scheduler will instantly shut down again.This has been reported as a problem for people following this design pattern: https://cylc.github.io/cylc-doc/stable/html/user-guide/examples/extending-workflow/index.html
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.