Skip to content

Fix cat-log test timing out#6945

Merged
oliver-sanders merged 1 commit intocylc:8.5.xfrom
MetRonnie:cat-log-test
Aug 27, 2025
Merged

Fix cat-log test timing out#6945
oliver-sanders merged 1 commit intocylc:8.5.xfrom
MetRonnie:cat-log-test

Conversation

@MetRonnie
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie commented Aug 27, 2025

Follow-up to #6871

When cat-log is run in tail mode, and the log file is deleted or the tail process is killed, cat-log exits after 60s since #6871.

However, the test tests/functional/cylc-cat-log/12-delete-kill.t is waiting 60s for the cat-log process to exit so the test has become slow + flaky.

This fix allows customising the interval for watching the tail process via an env var CYLC_PROC_POLL_INTERVAL so that the test can be made to run quickly.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are updated
  • Changelog entry not needed
  • Docs PR not needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.5.2 milestone Aug 27, 2025
@MetRonnie MetRonnie self-assigned this Aug 27, 2025
@oliver-sanders
Copy link
Copy Markdown
Member

Can't think of a better way!

@oliver-sanders oliver-sanders merged commit 0e257f9 into cylc:8.5.x Aug 27, 2025
28 checks passed
@MetRonnie MetRonnie deleted the cat-log-test branch August 27, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants