Merged
Conversation
* Closes cylc#6950 * Disable an upgrader-patched validation check which is incompatible with `cylc broadcast --cancel`.
MetRonnie
approved these changes
Sep 1, 2025
Member
MetRonnie
left a comment
There was a problem hiding this comment.
I've pushed a changelog entry
Contributor
|
Thanks for fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cylc broadcast --cancelTypeError when cancelling[events]setting #6950cylc broadcast --cancel.So
cylc broadcastruns config fragments viacylc.flow.cfgspec.workflowin order to run them through the upgraders.Cute, means you can still broadcast deprecated settings, not sure why we support that though?
We have patched some validation stuff into the upgrader (naughty) which is incompatible with this usage.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.