Skip to content

fix broadcast cancel error#6952

Merged
MetRonnie merged 2 commits intocylc:8.5.xfrom
oliver-sanders:6950
Sep 1, 2025
Merged

fix broadcast cancel error#6952
MetRonnie merged 2 commits intocylc:8.5.xfrom
oliver-sanders:6950

Conversation

@oliver-sanders
Copy link
Copy Markdown
Member

So cylc broadcast runs config fragments via cylc.flow.cfgspec.workflow in order to run them through the upgraders.

Cute, means you can still broadcast deprecated settings, not sure why we support that though?

We have patched some validation stuff into the upgrader (naughty) which is incompatible with this usage.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.5.2 milestone Aug 29, 2025
@oliver-sanders oliver-sanders self-assigned this Aug 29, 2025
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Aug 29, 2025
* Closes cylc#6950
* Disable an upgrader-patched validation check which is incompatible
  with `cylc broadcast --cancel`.
@oliver-sanders oliver-sanders changed the title 6950 fix broadcast cancel error Aug 29, 2025
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a changelog entry

@MetRonnie MetRonnie merged commit 765e36d into cylc:8.5.x Sep 1, 2025
11 of 24 checks passed
@MetRonnie MetRonnie linked an issue Sep 1, 2025 that may be closed by this pull request
@oliver-sanders oliver-sanders deleted the 6950 branch September 1, 2025 12:07
@matthewrmshin
Copy link
Copy Markdown
Contributor

Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is wrong :( small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cylc broadcast --cancel TypeError when cancelling [events] setting

3 participants